oliver/rss-news
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases 12 Packages Wiki Activity Actions

fix(telegram): async webhook handler + deduplicate callback responses

Browse source 
- Webhook returns 200 immediately, processing runs in background task
  → Telegram no longer retries, eliminates duplicate callbacks and 400 errors
- Consolidate answer_callback_query call to top of handler (before heavy work)
- Add logger.info/error for callback actions to aid debugging

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
OliverGiertz 2026-03-21 11:08:32 +00:00
parent 1020526e76
commit e9c472b722
2 changed files with 31 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

25
backend/app/telegram_bot.py
View file

@ -400,9 +400,19 @@ def _handle_callback(callback_query: dict[str, Any]) -> None:
answer_callback_query(query_id, "Artikel nicht gefunden")
return
# Answer Telegram immediately so the spinning indicator stops
action_labels = {
"rewrite": "✏️ Artikel wird neu geschrieben …",
"discard": "❌ Artikel verworfen",
"override": "➕ Artikel wird verarbeitet …",
"reject": "🚫 Abgelehnt",
}
answer_callback_query(query_id, action_labels.get(action, ""))
edit_message_reply_markup(chat_id, message_id)
logger.info("Callback: action=%s article_id=%s", action, article_id)
if action == "rewrite":
answer_callback_query(query_id, "✏️ Artikel wird neu geschrieben …")
edit_message_reply_markup(chat_id, message_id)
try:
_pipeline.rewrite_and_update_draft(article_id)
updated = get_article_by_id(article_id)
@ -411,28 +421,25 @@ def _handle_callback(callback_query: dict[str, Any]) -> None:
slot = suggest_publish_slot()
notify_new_draft(updated, score=_get_relevance_score(updated), suggested_publish_at=slot)
except Exception as exc:
logger.error("Rewrite #%d fehlgeschlagen: %s", article_id, exc)
notify_error(f"Rewrite #{article_id} fehlgeschlagen: {exc}")
elif action == "discard":
answer_callback_query(query_id, "❌ Artikel verworfen")
edit_message_reply_markup(chat_id, message_id)
try:
_pipeline.discard_article(article_id)
except Exception as exc:
logger.error("Discard #%d fehlgeschlagen: %s", article_id, exc)
notify_error(f"Verwerfen #{article_id} fehlgeschlagen: {exc}")
elif action == "override":
answer_callback_query(query_id, "➕ Artikel wird verarbeitet …")
edit_message_reply_markup(chat_id, message_id)
try:
_pipeline.override_rejected_article(article_id)
except Exception as exc:
logger.error("Override #%d fehlgeschlagen: %s", article_id, exc)
notify_error(f"Override #{article_id} fehlgeschlagen: {exc}")
elif action == "reject":
answer_callback_query(query_id, "🚫 Abgelehnt")
edit_message_reply_markup(chat_id, message_id)
update_article_status(article_id, "error", actor="telegram", note="Manuell abgelehnt via Telegram")
else:
answer_callback_query(query_id, "Unbekannte Aktion")
logger.warning("Unbekannte Callback-Aktion: %s", action)